Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add codecv3 for darwin batches #866

Merged
merged 5 commits into from
Jul 9, 2024
Merged

feat: add codecv3 for darwin batches #866

merged 5 commits into from
Jul 9, 2024

Conversation

amoylan2
Copy link
Member

1. Purpose or design rationale of this PR

add codecv3 for darwin batches

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

colinlyguo
colinlyguo previously approved these changes Jun 27, 2024
0xmountaintop
0xmountaintop previously approved these changes Jul 4, 2024
@colinlyguo colinlyguo changed the title [WIP]: feat: add codecv3 for darwin batches feat: add codecv3 for darwin batches Jul 8, 2024
@colinlyguo
Copy link
Member

will add the unit test in another PR.

@github-actions github-actions bot dismissed stale reviews from colinlyguo and 0xmountaintop via 202a1c4 July 8, 2024 08:43
@colinlyguo colinlyguo requested a review from georgehao July 8, 2024 08:45
georgehao
georgehao previously approved these changes Jul 8, 2024
@colinlyguo
Copy link
Member

merged for local testing.

@colinlyguo colinlyguo merged commit 15019ef into develop Jul 9, 2024
8 checks passed
@colinlyguo colinlyguo deleted the feat/codecv3 branch July 9, 2024 06:15
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
* feat: add codecv3 for darwin batches

* fix lint issue

* chore: auto version bump [bot]

* update da-codec dependency

---------

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
Co-authored-by: colinlyguo <colinlyguo@scroll.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants