Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(txpool): StatsWithMinBaseFee #884

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Conversation

jonastheis
Copy link

1. Purpose or design rationale of this PR

When the base fee changes, transactions which are now below the base fee, stay in the txpool as pending. However, since we use the amount of pending tx in the GPO to determine the current congestion level of the network, this wouldn't yield any meaningful information anymore.

This PR, therefore, introduces a function StatsWithMinBaseFee to the txpool so that the GPO can query the pending transactions that are meaningful right now.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

core/tx_pool.go Outdated Show resolved Hide resolved
omerfirmak
omerfirmak previously approved these changes Jul 8, 2024
0xmountaintop
0xmountaintop previously approved these changes Jul 8, 2024
Thegaram
Thegaram previously approved these changes Jul 9, 2024
core/tx_pool.go Show resolved Hide resolved
core/tx_pool.go Show resolved Hide resolved
@Thegaram Thegaram merged commit 8c7a3ae into develop Jul 10, 2024
@Thegaram Thegaram deleted the jt/txpool-stats-min-basefee branch July 10, 2024 09:11
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
* feat(txpool): implement StatsWithMinBaseFee

* feat(gpo): use StatsWithMinBaseFee to filter out tx below the current blocks base fee

* feat(les/txpool): implement StatsWithMinBaseFee

* use flatten() (lowercase) to avoid copying of tx list

* chore: auto version bump [bot]

---------

Co-authored-by: jonastheis <jonastheis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants