fix(rollup-verifier): decode commitBatchWithBlobProof calldata #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hBlobProof-calldata
colinlyguo
commented
Jul 10, 2024
0xmountaintop
previously approved these changes
Jul 11, 2024
zimpha
previously approved these changes
Jul 11, 2024
…hBlobProof-calldata
Thegaram
previously approved these changes
Jul 12, 2024
…hBlobProof-calldata
Thegaram
dismissed stale reviews from 0xmountaintop, zimpha, and themself
via
43d864e
Thegaram
approved these changes
Jul 12, 2024
zimpha
approved these changes
Jul 12, 2024
colinlyguo
deleted the
fix-rollup-verifier-decode-commitBatchWithBlobProof-calldata
branch
lwedge99
pushed a commit
to sentioxyz/scroll-geth
that referenced
this pull request
Aug 27, 2024
…l-tech#896) fix(rollup-verifier): decode commitBatchWithBlobProof Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
This PR fixes the bug that current rollup verifier cannot decode
commitBatchWithBlobProof's calldata.This also adds unit tests fetched from local testnet
commitBatchWithBlobProoftransactions.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?