Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat JSON errors as CCC error #922

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented Jul 24, 2024

1. Purpose or design rationale of this PR

Encoding related errors were already treated as CCC error before spllitting up CCC and encoding stage in to seperate stages. This way we can skip txns that fail in encoding stage as well.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@omerfirmak omerfirmak merged commit e3bfb5f into develop Jul 25, 2024
8 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/treating-json-err-as-ccc-error branch July 25, 2024 14:35
0xmountaintop added a commit that referenced this pull request Jul 29, 2024
fix: treat JSON errors as CCC error (#922)

Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
achmand pushed a commit to draganm/go-ethereum that referenced this pull request Aug 13, 2024
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants