Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Scroll Binary Patricia Merkle Trie Components #36

Merged
merged 50 commits into from
Dec 8, 2024
Merged

Introduce Scroll Binary Patricia Merkle Trie Components #36

merged 50 commits into from
Dec 8, 2024

Conversation

frisitano
Copy link
Collaborator

Overview

This PR introduces the primitive binary Merkle Patricia trie components required for scroll.

WIP

@frisitano frisitano changed the base branch from main to scroll November 20, 2024 03:22
@frisitano frisitano mentioned this pull request Nov 20, 2024
Closed
@frisitano
refactor: introduce StateCommimentProvider
52426db
@frisitano
Merge remote-tracking branch 'upstream/main' into feat/provider-state…
3a9fa49 
…-commitment
@frisitano
feat: introduce HashedPostStateProvider
10af3b1
@frisitano
Merge remote-tracking branch 'upstream/main' into feat/provider-state…
57544dd 
…-commitment
@frisitano
Merge branch 'feat/provider-state-commitment' into feat/hashed-post-s…
5f6977e 
…tate-provider
@frisitano
feat: HashedPostState from reverts
500f8c2
@frisitano
feat: introduce HashedStorageProvider
8b24bc3
@frisitano
lint: revm/test-utils feature propogation
0e79635
@frisitano
Merge branch 'feat/hashed-post-state-provider' into feat/hashed-stora…
9a66c9d 
…ge-provider
@frisitano
fix: add Send + Sync bound on introduced storage state api methods
593587e
@frisitano
Merge branch 'feat/hashed-post-state-provider' into feat/hashed-stora…
59a99c8 
…ge-provider
@frisitano
feat: introduce KeyHasherProvider
dbeb344
@frisitano
feat: introduce StateRootProviderExt and integrate it (and StateRootP…
60b4f7a 
…rovider) with StateCommitment
frisitano
frisitano commented Nov 27, 2024
View reviewed changes
Copy link
Collaborator Author

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments inline that need to be addressed.

crates/scroll/primitives/src/lib.rs Outdated Show resolved Hide resolved
crates/scroll/state-commitment/src/key.rs Outdated Show resolved Hide resolved
crates/scroll/state-commitment/src/root.rs Show resolved Hide resolved
crates/scroll/state-commitment/src/root.rs Outdated Show resolved Hide resolved
crates/scroll/state-commitment/src/root.rs Outdated Show resolved Hide resolved
crates/trie/trie/src/updates.rs Outdated Show resolved Hide resolved
crates/trie/trie/src/walker.rs Outdated Show resolved Hide resolved
crates/trie/trie/src/walker.rs Outdated Show resolved Hide resolved
crates/trie/trie/src/witness.rs Outdated Show resolved Hide resolved
crates/trie/trie/src/witness.rs Outdated Show resolved Hide resolved
@frisitano frisitano marked this pull request as ready for review December 5, 2024 10:34
@frisitano frisitano changed the title WIP: Introduce Scroll Binary Patricia Merkle Trie Components Introduce Scroll Binary Patricia Merkle Trie Components Dec 5, 2024
georgehao
georgehao reviewed Dec 5, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
greged93
greged93 reviewed Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits and a question

Cargo.toml Outdated Show resolved Hide resolved
crates/blockchain-tree/Cargo.toml Outdated Show resolved Hide resolved
crates/scroll/primitives/src/account_extension.rs Show resolved Hide resolved
crates/scroll/state-commitment/src/value.rs Outdated Show resolved Hide resolved
crates/scroll/primitives/src/poseidon.rs Show resolved Hide resolved
crates/stages/stages/src/stages/execution.rs Outdated Show resolved Hide resolved
@georgehao georgehao mentioned this pull request Dec 6, 2024
Merged
This was referenced Dec 7, 2024
Open
Open
@frisitano frisitano requested a review from greged93 December 7, 2024 14:25
greged93
greged93 previously approved these changes Dec 8, 2024
View reviewed changes
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit, otherwise lgtm!

crates/scroll/state-commitment/Cargo.toml Outdated Show resolved Hide resolved
@frisitano frisitano requested a review from greged93 December 8, 2024 13:52
greged93
greged93 approved these changes Dec 8, 2024
View reviewed changes
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@frisitano frisitano merged commit 883d508 into scroll Dec 8, 2024
41 checks passed
@frisitano frisitano deleted the feat/scroll-bmpt branch December 8, 2024 14:26
This was referenced Dec 9, 2024
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehao georgehao georgehao left review comments

@greged93 greged93 greged93 approved these changes

@Thegaram Thegaram Awaiting requested review from Thegaram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frisitano @georgehao @greged93