Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: l1_fee field on Receipt #42

Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat: l1_fee field on Receipt #42

merged 1 commit into from
Nov 28, 2024

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Nov 23, 2024

This PR builds on top of #41 and should only be reviewed once 41 is merged.

Adds the l1_fee field on the primitives Receipt from Reth.
Skips the field when RLP encoding the Receipt as the l1_fee field is not part of the consensus encoding of the receipt. The field is still included in the Compact implementation meaning the Receipt will be saved in storage with the L1 fee.

Builds towards #7

@greged93 greged93 force-pushed the feat/scroll-transaction branch from 5b01075 to 91c5b0d Compare November 26, 2024 11:03
@greged93 greged93 force-pushed the feat/scroll-receipt branch from 32844ae to 3ca3d33 Compare November 26, 2024 16:49
@greged93 greged93 force-pushed the feat/scroll-transaction branch from 91c5b0d to 675c027 Compare November 28, 2024 08:52
Base automatically changed from feat/scroll-transaction to scroll November 28, 2024 14:35
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
@greged93 greged93 force-pushed the feat/scroll-receipt branch from 3ca3d33 to 445e0d0 Compare November 28, 2024 15:36
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. LGTM!

@frisitano frisitano merged commit 5b151dd into scroll Nov 28, 2024
39 checks passed
@frisitano frisitano deleted the feat/scroll-receipt branch November 28, 2024 15:58
@frisitano frisitano mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants