feat: support directly forward transactions to sequencer

[yiweichi]

Counterpart of l2geth scroll-tech/go-ethereum#1208.
Related Reth PR: scroll-tech/reth#265

Added a new flags on NetworkArgs.
network.sequencer-url: This will be passed to ScrollEthApiBuilder, If not None, Reth will forward transactions to sequencer's RPC directly.

[frisitano]

Added comment inline.

[frisitano]

Can we add an e2e test for this using the test framework. See example provided:

rollup-node/crates/node/tests/e2e.rs

Lines 94 to 95 in 1ffce34

	#[tokio::test]
	async fn can_sequence_and_gossip_blocks() {

[yiweichi]

Can we add an e2e test for this using the test framework. See example provided:

rollup-node/crates/node/tests/e2e.rs

Lines 94 to 95 in 1ffce34

	#[tokio::test]
	async fn can_sequence_and_gossip_blocks() {

Sure, let me do that.

[frisitano]

Sure, let me do that.

Thanks, I think you'll need to set no_local_transactions_propagation to true in the node config when launching the test nodes:

https://github.com/scroll-tech/reth/blob/766dd271b0bd71315cef665d1eeb81ab86b891e0/crates/node/core/src/args/txpool.rs#L90-L92

[yiweichi]

Sure, let me do that.

Thanks, I think you'll need to set no_local_transactions_propagation to true in the node config when launching the test nodes:

https://github.com/scroll-tech/reth/blob/766dd271b0bd71315cef665d1eeb81ab86b891e0/crates/node/core/src/args/txpool.rs#L90-L92

During testing, the arg no_local_transactions_propagation does't work well, I think it is a bug on Reth, see the fix commit here. Essentially Reth does't pass no_local_transactions_propagation to TransactionValidationTaskExecutor but just put a default value. Which makes even with arg no_local_transactions_propagation set to true, the node will still propagate transaction.

[frisitano]

Looks good. Left a few minor comments inline. Lets work on getting feat-forward-tx-to-sequencer merged into scroll branch on reth and then we can look to get this merged.

[frisitano]

Please remove branch = "feat-forward-tx-to-sequencer", from Cargo.toml files as we have now merged reth PR into default branch (scroll).

[yiweichi]

Please remove branch = "feat-forward-tx-to-sequencer", from Cargo.toml files as we have now merged reth PR into default branch (scroll).

branch updated.

[frisitano]

lgtm