Skip to content

chore: replace contract addresses with explorer URLs #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

roynalnaruto
Copy link
Contributor

@roynalnaruto roynalnaruto commented Oct 17, 2023

Closing issues

closes #109

Description

Replaces the plain text contract addresses with URLs that link them to the appropriate pages on Scrollscan or Etherscan (or the corresponding Sepolia explorer pages)

Changes

  • Replace plain texts with links

@roynalnaruto roynalnaruto requested a review from dghelm October 17, 2023 16:48
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit 1f91c8c
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/652ebbb2249e150008cac50e
😎 Deploy Preview https://deploy-preview-110.docs.scroll.xyz/en/developers/scroll-contracts
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dghelm dghelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition -- thanks!

@dghelm dghelm merged commit 95d8d3e into develop Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Contract addresses should ideally link to the explorer for a better experience
2 participants