Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode #127

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Dark mode #127

merged 7 commits into from
Dec 12, 2023

Conversation

Holybasil
Copy link
Member

@Holybasil Holybasil commented Nov 22, 2023 •
edited by yqrashawn
Loading

@netlify Netlify
Copy link

netlify bot commented Nov 22, 2023 •
edited
Loading

✅ Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit 709ec20
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/656e78d857d5a200080b0168
😎 Deploy Preview https://deploy-preview-127.docs.scroll.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Holybasil Holybasil marked this pull request as ready for review November 27, 2023 04:45
@Holybasil Holybasil requested review from zzq0826 and dghelm November 28, 2023 01:53
zzq0826
zzq0826 previously approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@zzq0826 zzq0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Holybasil Holybasil requested a review from zzq0826 December 5, 2023 01:12
Turupawn
Turupawn approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@Turupawn Turupawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this navigating on pages on the preview and locally. Also did a quick scroll though the code and LGTM

@dghelm dghelm merged commit 6815706 into develop Dec 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turupawn Turupawn Turupawn approved these changes

@dghelm dghelm Awaiting requested review from dghelm

@zzq0826 zzq0826 Awaiting requested review from zzq0826

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Holybasil @Turupawn @zzq0826 @dghelm