Guide for adding Canvas badges #333

isabellewei · 2024-09-06T21:13:23Z

No description provided.

netlify · 2024-09-06T21:13:39Z

✅ Deploy Preview for scroll-documentation ready!

Name	Link
🔨 Latest commit	`d29d1e8`
🔍 Latest deploy log	https://app.netlify.com/sites/scroll-documentation/deploys/670949947ab2bd0008be6645
😎 Deploy Preview	https://deploy-preview-333.docs.scroll.xyz
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-09-13T12:20:41Z

Hannah Shen left a comment:

Link to dev support should be changed to https://discord.com/invite/scroll

Browser metadata

Path:      /en/developers/guides/canvas-badge-integration/#step-1-badge-design-guidelines-design
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

netlify · 2024-09-13T12:21:42Z

Hannah Shen left a comment:

should we add API requirements in this doc too? Instead of redirecting to notion

Browser metadata

Path:      /en/developers/guides/canvas-badge-integration/#step-1-badge-design-guidelines-design
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

netlify · 2024-09-13T12:22:54Z

Hannah Shen left a comment:

Under Issuance method: Gifted and Back-end authorized both require API check. Sync on formatting and add that Gifted requires a Check API

Browser metadata

Path:      /en/developers/guides/canvas-badge-integration/#step-1-badge-design-guidelines-design
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

netlify · 2024-09-13T12:25:36Z

Hannah Shen left a comment:

Extra boost section: Unbold the content?

Browser metadata

Path:      /en/developers/guides/canvas-badge-integration/#reference-cors
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

netlify · 2024-09-13T12:26:28Z

Hannah Shen left a comment:

for Scroll Canvas - Anthropomorphic “assistants” Integration Guide for Developers https://www.notion.so/scrollzkp/Scroll-Canvas-Anthropomorphic-assistants-Integration-Guide-for-Developers-2712f7a91af042c0a2d145af804bab51 let's merge it here as well to smooth the flow?

Browser metadata

Path:      /en/developers/guides/canvas-badge-integration/#reference-cors
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

netlify · 2024-09-13T12:27:24Z

Hannah Shen left a comment:

Under Badge section, we can link EAS learning page for people get famimilar with Attestation https://scroll.easscan.org/learn/scroll

Browser metadata

Path:      /en/developers/guides/canvas-badge-integration/#reference-cors
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

* fix the title * Unbold the text under toggle list

* fix the title * Unbold the text under toggle list * Update the content

Thegaram

Overall looks good, just nitpicks.

src/content/docs/en/developers/guides/canvas-badge-integration.mdx

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* fix the title * Unbold the text under toggle list * Update the content * update content based on the comments --------- Co-authored-by: isabellewei <isabelle.wei@yahoo.ca>

* Darwinv2 changes (#332) * darwinv2 changes * oops * note on reorgs and finality * formatting * added guide for the graph (#334) * add alchemy to scroll tools * update text in alchemy.mdx * add 0x to dev tooling explorer * fix feedback * Guide for adding Canvas badges (#333) * add Canvas guide * fix * add to nav * display images side by side * feedback * add image margins * fix the title (#337) * Update the content detail and unbold text (#341) * fix the title * Unbold the text under toggle list * Update the content (#348) * fix the title * Unbold the text under toggle list * Update the content * small edits * Apply suggestions from code review Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * Isabellewei/canvas (#367) * fix the title * Unbold the text under toggle list * Update the content * update content based on the comments --------- Co-authored-by: isabellewei <isabelle.wei@yahoo.ca> --------- Co-authored-by: fanyarachel <43579854+fanyarachel@users.noreply.github.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io> --------- Co-authored-by: AK <alikim@gmail.com> Co-authored-by: Sahil Aujla <sahilaujla15@gmail.com> Co-authored-by: emilyJLin95 <17280653+emilyJLin95@users.noreply.github.com> Co-authored-by: Jessica Lin <jlin2700@gmail.com> Co-authored-by: fanyarachel <43579854+fanyarachel@users.noreply.github.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* feat: Add turkish transalation (build fix) (#256) (#257) * lang "tr" added, sections "getting-started" and "user-guide" is translated accordingly * Update overview.md * technology/bridge turkish translations are added * lang[tr] user-guide finalized * learn added, getting started improvements * /learn and most of the /technology is translated to lang[tr] * /technology/chain finished * /developers section translations to lang[tr] * /developers developer-quickstart and transaction-fees-on-scroll translated to lang[tr] * /developers section finished except guides part. some other language correctments in lang[tr] * execution-node-tr completed * rollup-node-tr completed * /developers/guides is completed * added lang[tr] for welcome page frontend * cross-domain-messaging-tr completed * deposit-gateways-tr completed * withdraw-gateways-tr completed * minor improvements * visual bugs fixed in kzg schemes lang[tr] * minor improvements * general language improvements and word suffix correctments lang[tr] * translation completions of some overlooked technical terms lang[tr] * minor fix * term improvements * minor improvements in terms * minor punctuation suffix correction * minor punctuation suffix fixes * more minor improvements * minor update * zktrie.mdx güncelleme * refactor * /technology/sequencer/zktrie.mdx translation completed * refactor * mini typo in kzg schemes * mempool changes * Bridge part refactor * Withdraw-gateways refactor * Minor translation fixes in Learn folder. * Zktrie and Zkevm part * minor corrections in translations of rollup, opcode and hash * minor corrections in gateway translation * minor translation corrections * "SB" changed to ZK in get started, learn and devs * "Haberci"ler "Messenger"a donusturuldu. * local preview fixes * proof read "getting started" "user guide" "learn" * punctuation mistake while proof reading * getting started/user guide/learn proofread finished, front page translation updates, menu.ts is translated, some parts of translation.js is translated * minor changes in index and overview * tr/technology/chain proofread and corrections completed * syntax corrections in tr/technology/overview * Typo correction in chain/blocks * json translations * translation json translated * "Baslayin" changed to "Basla" in Menu * /tr/technology/bridge proofread completed, corrections made * /tr/technology/sequencer proofread, corrections completed * /tr/technology/zkevm and /tr/technology/security proofread and corrections completed * technology subheaders translation changed * mini term fix * Proof read dev * Warning titles have been changed * minor changes * a link, a prefix, and a minor main page correction * fix: npm run build now works with node 18.14.1 --------- Co-authored-by: emremreistaken <emre.guclu@metu.edu.tr> Co-authored-by: emremre <101284529+emremreistaken@users.noreply.github.com> Co-authored-by: memduh <memduhbayram0@gmail.com> Co-authored-by: bahribugra <bbugrameydan@gmail.com> Co-authored-by: Dilara <dilara.anabolu@gmail.com> * Curie updates (#289) * Curie updates (#271) * curie-update-libzkp-version * security nit * move contact info into highlight * change Aside type * Update running-a-scroll-node.mdx (#278) * nodeKey hashing are done with domain 512 not 256 Am currently making a storage prover in noir and found this error In the zktrie repo nodekeys are hashed with ToSecureKey() in type/util.go (afaik) https://github.com/scroll-tech/zktrie/blob/23181f209e94137f74337b150179aeb80c72e7c8/types/util.go#L107 ToSecureKey() uses Hash() in types/bytes32.go which uses HASH_DOMAIN_BYTE32 as domain which is 256 *2 (512) see here: https://github.com/scroll-tech/zktrie/blob/23181f209e94137f74337b150179aeb80c72e7c8/types/hash.go#L16 and here is where i did my test in noir :D (account leaf is lower in same file) https://github.com/jimjimvalkema/scrollZkStorageProofs/blob/bcdd922405e046e99787b8b47f374befac170779/ScrollStorageProver/src/main.nr#L168 * add get in touch button * Revert "add get in touch button" This reverts commit 5c695f2. * Curie update details (#286) * remove legacy flag for foundry * update Curie details * fix typo * oops * Add PR descriptions --------- Co-authored-by: colinlyguo <colinlyguo@scroll.io> Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com> Co-authored-by: Sina Pilehchiha <sina@scroll.io> Co-authored-by: Péter Garamvölgyi <peter@scroll.io> Co-authored-by: jimjimvalkema <jjvalkema@protonmail.com> Co-authored-by: Daniel Helm <dan.helm@gmail.com> Co-authored-by: zhengqi zhang <770166635@qq.com> * Merge pull request #338 from SahilAujla/develop add alchemy to scroll tools * Merge pull request #342 from jlin27/develop add 0x to dev tooling explorer * Merge to prod (#349) * Darwinv2 changes (#332) * darwinv2 changes * oops * note on reorgs and finality * formatting * added guide for the graph (#334) * add alchemy to scroll tools * update text in alchemy.mdx * add 0x to dev tooling explorer * fix feedback --------- Co-authored-by: AK <alikim@gmail.com> Co-authored-by: Sahil Aujla <sahilaujla15@gmail.com> Co-authored-by: emilyJLin95 <17280653+emilyJLin95@users.noreply.github.com> Co-authored-by: Jessica Lin <jlin2700@gmail.com> * Publish Canvas guide (#371) * Darwinv2 changes (#332) * darwinv2 changes * oops * note on reorgs and finality * formatting * added guide for the graph (#334) * add alchemy to scroll tools * update text in alchemy.mdx * add 0x to dev tooling explorer * fix feedback * Guide for adding Canvas badges (#333) * add Canvas guide * fix * add to nav * display images side by side * feedback * add image margins * fix the title (#337) * Update the content detail and unbold text (#341) * fix the title * Unbold the text under toggle list * Update the content (#348) * fix the title * Unbold the text under toggle list * Update the content * small edits * Apply suggestions from code review Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * Isabellewei/canvas (#367) * fix the title * Unbold the text under toggle list * Update the content * update content based on the comments --------- Co-authored-by: isabellewei <isabelle.wei@yahoo.ca> --------- Co-authored-by: fanyarachel <43579854+fanyarachel@users.noreply.github.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io> --------- Co-authored-by: AK <alikim@gmail.com> Co-authored-by: Sahil Aujla <sahilaujla15@gmail.com> Co-authored-by: emilyJLin95 <17280653+emilyJLin95@users.noreply.github.com> Co-authored-by: Jessica Lin <jlin2700@gmail.com> Co-authored-by: fanyarachel <43579854+fanyarachel@users.noreply.github.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * add pyth to scroll * fix pyth excerpt * fix typos --------- Co-authored-by: Daniel Helm <dan.helm@gmail.com> Co-authored-by: Ahmed Castro <ahmed.hn.43@gmail.com> Co-authored-by: emremreistaken <emre.guclu@metu.edu.tr> Co-authored-by: emremre <101284529+emremreistaken@users.noreply.github.com> Co-authored-by: memduh <memduhbayram0@gmail.com> Co-authored-by: bahribugra <bbugrameydan@gmail.com> Co-authored-by: Dilara <dilara.anabolu@gmail.com> Co-authored-by: isabellewei <isabelle.wei@yahoo.ca> Co-authored-by: colinlyguo <colinlyguo@scroll.io> Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com> Co-authored-by: Sina Pilehchiha <sina@scroll.io> Co-authored-by: Péter Garamvölgyi <peter@scroll.io> Co-authored-by: jimjimvalkema <jjvalkema@protonmail.com> Co-authored-by: zhengqi zhang <770166635@qq.com> Co-authored-by: vincent <cj1436@nyu.edu> Co-authored-by: ChuhanJin <60994121+ChuhanJin@users.noreply.github.com> Co-authored-by: emilyJLin95 <17280653+emilyJLin95@users.noreply.github.com> Co-authored-by: AK <alikim@gmail.com> Co-authored-by: Sahil Aujla <sahilaujla15@gmail.com> Co-authored-by: Jessica Lin <jlin2700@gmail.com> Co-authored-by: fanyarachel <43579854+fanyarachel@users.noreply.github.com> Co-authored-by: Morty <70688412+yiweichi@users.noreply.github.com>

add Canvas guide

2c69d60

isabellewei added 5 commits September 6, 2024 17:51

fix

58b4507

add to nav

102c6da

display images side by side

6e49710

feedback

7155ca3

add image margins

1d7d762

fanyarachel and others added 4 commits September 23, 2024 17:28

fix the title (#337)

6fecb31

Update the content detail and unbold text (#341)

1d45c40

* fix the title * Unbold the text under toggle list

Update the content (#348)

a4b98c2

* fix the title * Unbold the text under toggle list * Update the content

small edits

2921313

fanyarachel approved these changes Oct 2, 2024

View reviewed changes

Thegaram previously approved these changes Oct 3, 2024

View reviewed changes

Apply suggestions from code review

a5ac8f3

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

isabellewei dismissed Thegaram’s stale review via a5ac8f3 October 3, 2024 20:43

isabellewei requested a review from Thegaram October 3, 2024 20:47

Isabellewei/canvas (#367)

d29d1e8

* fix the title * Unbold the text under toggle list * Update the content * update content based on the comments --------- Co-authored-by: isabellewei <isabelle.wei@yahoo.ca>

Thegaram approved these changes Oct 11, 2024

View reviewed changes

isabellewei merged commit da760fa into develop Oct 15, 2024
6 checks passed

isabellewei deleted the isabellewei/canvas branch October 15, 2024 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Guide for adding Canvas badges #333

Guide for adding Canvas badges #333

isabellewei commented Sep 6, 2024

netlify bot commented Sep 6, 2024 •

edited

Loading

netlify bot commented Sep 13, 2024

netlify bot commented Sep 13, 2024

netlify bot commented Sep 13, 2024

netlify bot commented Sep 13, 2024

netlify bot commented Sep 13, 2024

netlify bot commented Sep 13, 2024

Thegaram left a comment

Guide for adding Canvas badges #333

Guide for adding Canvas badges #333

Conversation

isabellewei commented Sep 6, 2024

netlify bot commented Sep 6, 2024 • edited Loading

✅ Deploy Preview for scroll-documentation ready!

netlify bot commented Sep 13, 2024

netlify bot commented Sep 13, 2024

netlify bot commented Sep 13, 2024

netlify bot commented Sep 13, 2024

netlify bot commented Sep 13, 2024

netlify bot commented Sep 13, 2024

Thegaram left a comment

Choose a reason for hiding this comment

netlify bot commented Sep 6, 2024 •

edited

Loading