-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docs about L1 follower node #374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabellewei
previously approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple comments
src/content/docs/en/developers/guides/running-a-scroll-node.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/developers/guides/running-a-scroll-node.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/developers/guides/running-a-scroll-node.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/developers/guides/running-a-scroll-node.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/developers/guides/running-a-scroll-node.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/developers/guides/running-a-scroll-node.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: isabellewei <isabelle.wei@yahoo.ca>
✅ Deploy Preview for scroll-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: isabellewei <isabelle.wei@yahoo.ca>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thegaram
previously approved these changes
Dec 18, 2024
Will merge once scroll-tech/go-ethereum#1098 is merged. |
Thegaram
approved these changes
Dec 19, 2024
zzq0826
added a commit
that referenced
this pull request
Dec 19, 2024
feat: add docs about L1 follower node (#374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds documentation and running instructions for the L1 follower mode of L2geth which was implemented in this PR: scroll-tech/go-ethereum#1013