Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update: Adding Reown as one of the Tooling deployed on Scroll #401

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

rohit-710
Copy link
Contributor

Closing issues

closes #400
...

Description

This PR adds another developer tooling deployed on Scroll, that is, Reown (prev. known as WalletConnect).

...

Changes

Adds another .mdx file within /tools/en folder. The markdown file also contains information about Reown and its two major SDKs for user onboarding and wallets.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit 2759814
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/674829bf87c6420008f31e3f
😎 Deploy Preview https://deploy-preview-401.docs.scroll.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emilyJLin95
Copy link
Collaborator

@rohit-710 the UI looks off? Can you fix?
Uploading Screenshot 2024-11-28 at 9.57.45 AM.png…

@rohit-710
Copy link
Contributor Author

Hey @emilyJLin95, I am unable to see the image that you uploaded along with your comment. I think there was an issue when you tried uploading the image.

I think I see what you mean. I'll fix it now

@rohit-710
Copy link
Contributor Author

rohit-710 commented Nov 28, 2024

Screenshot 2024-11-28 at 9 32 07 AM

@emilyJLin95 I just fixed it. The issue comes from how your codebase's frontend handles these .mdx files. Upon a closer look, it occurs if the name or the title is a bit long. Please take a look at the screenshot that I have attached where "Ethereum Attestation Service" has the same issue.

@emilyJLin95
Copy link
Collaborator

@rohit-710 good catch! I'll make an issue for the team otherwise LGTM

Copy link
Collaborator

@emilyJLin95 emilyJLin95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilyJLin95 emilyJLin95 merged commit 14aefa8 into scroll-tech:develop Dec 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Content]: Adding Reown as one of the toolings deployed on Scroll
2 participants