Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add capacity for RLP circuit #255

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Feat: add capacity for RLP circuit #255

merged 1 commit into from
Sep 2, 2023

Conversation

kunxian-xia
Copy link
Contributor

We want to have 2*MAX_CALLDATA < MAX_RLP_ROWS because each call data byte in a L2 tx takes two rows in the RLP circuit.

  • add capacity for RLP circuit: 800k
  • downsize the capacity of Tx circuit: 600k -> 350k since a batch can only have less than 200KB in the rollup contract.

@silathdiir silathdiir requested a review from lispc August 31, 2023 22:54
@lispc lispc merged commit 95220cd into main Sep 2, 2023
@lispc lispc deleted the feat/rlp-capacity branch September 2, 2023 05:56
cyphersnake pushed a commit to cyphersnake/scroll-prover that referenced this pull request Jul 30, 2024
@kunxian-xia
Bug-fix: make the tx circuit universal universal (scroll-tech#255)
ad3e81f 
* fix: make tx circuit universal

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lispc lispc Awaiting requested review from lispc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunxian-xia @lispc