feat(l1 message): nonce, code and base fee checks #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisitano
approved these changes
Aug 4, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Looks good. Would be nice to run some test cases for this comparing l2geth and reth to verify the correctness of this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the following update to the L1 message validation rules:
validate_account_nonce_and_codecall.The base fee and nonce checks were previously skipped in Reth in the
ScrollBlockExecutorby configuring the evm. In tracing, theScrollEvmis used instead, which doesn't allow us to apply the config (or would require us to make modifications to the Reth codebase, further diverging from upstream). Moving away from this custom config we need to apply everytime for L1 messages to correct handling of the checks in the handler makes more sense.