Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macos whoami issue #214

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: macos whoami issue #214

merged 1 commit into from
Oct 31, 2024

Conversation

dghelm
Copy link
Contributor

@dghelm dghelm commented Oct 31, 2024

Because this seems to be a permissions issue on linux, I'm removing it from macOS flow.

Sudo access isn't great, and macOS doesn't use the same user:group convention as Ubuntu, so it throws an error.

@dghelm dghelm requested review from Turupawn and yiweichi October 31, 2024 06:44
Copy link
Member

@yiweichi yiweichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiweichi yiweichi merged commit 3c6e315 into develop Oct 31, 2024
@yiweichi yiweichi deleted the oct-testing branch October 31, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants