Can you please help review my pr?

Here's the pull request I submitted three weeks ago: https://github.com/scroll-tech/scroll/pull/1184.
While it was initially approved, I've since made some fixes in the test. It requires another review.