-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: do not update fee if not committing batches #1441
Merged
NazariiDenha
merged 16 commits into
develop
from
feat/not-update-fee-if-not-committing-batches
Aug 18, 2024
Merged
feat: do not update fee if not committing batches #1441
NazariiDenha
merged 16 commits into
develop
from
feat/not-update-fee-if-not-committing-batches
Aug 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NazariiDenha
changed the title
do not update fee if not committing batches
feat: do not update fee if not committing batches
Jul 15, 2024
Thegaram
reviewed
Jul 15, 2024
…-update-fee-if-not-committing-batches
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1441 +/- ##
===========================================
+ Coverage 52.49% 52.50% +0.01%
===========================================
Files 156 156
Lines 12497 12523 +26
===========================================
+ Hits 6560 6575 +15
- Misses 5374 5382 +8
- Partials 563 566 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
colinlyguo
reviewed
Jul 24, 2024
NazariiDenha
force-pushed
the
feat/not-update-fee-if-not-committing-batches
branch
from
August 1, 2024 08:43
365ebc4
to
bd863d8
Compare
colinlyguo
previously approved these changes
Aug 1, 2024
zimpha
reviewed
Aug 2, 2024
georgehao
reviewed
Aug 2, 2024
georgehao
reviewed
Aug 2, 2024
georgehao
reviewed
Aug 2, 2024
…-update-fee-if-not-committing-batches
colinlyguo
previously approved these changes
Aug 5, 2024
colinlyguo
reviewed
Aug 5, 2024
colinlyguo
reviewed
Aug 5, 2024
colinlyguo
reviewed
Aug 5, 2024
zimpha
previously approved these changes
Aug 5, 2024
…-update-fee-if-not-committing-batches
colinlyguo
previously approved these changes
Aug 14, 2024
colinlyguo
approved these changes
Aug 16, 2024
zimpha
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
task
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?