Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not update fee if not committing batches #1441

Merged
merged 16 commits into from
Aug 18, 2024

Conversation

NazariiDenha
Copy link
Contributor

Purpose or design rationale of this PR

task

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@NazariiDenha NazariiDenha changed the title do not update fee if not committing batches feat: do not update fee if not committing batches Jul 15, 2024
rollup/internal/controller/relayer/l1_relayer.go Outdated Show resolved Hide resolved
rollup/internal/controller/relayer/l1_relayer.go Outdated Show resolved Hide resolved
rollup/conf/config.json Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.50%. Comparing base (160f4c4) to head (89bf4d9).

Files Patch % Lines
rollup/internal/controller/relayer/l1_relayer.go 73.07% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1441      +/-   ##
===========================================
+ Coverage    52.49%   52.50%   +0.01%     
===========================================
  Files          156      156              
  Lines        12497    12523      +26     
===========================================
+ Hits          6560     6575      +15     
- Misses        5374     5382       +8     
- Partials       563      566       +3     
Flag Coverage Δ
rollup 57.02% <73.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NazariiDenha NazariiDenha force-pushed the feat/not-update-fee-if-not-committing-batches branch from 365ebc4 to bd863d8 Compare August 1, 2024 08:43
@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Aug 1, 2024
colinlyguo
colinlyguo previously approved these changes Aug 1, 2024
rollup/internal/controller/relayer/l1_relayer.go Outdated Show resolved Hide resolved
rollup/conf/config.json Outdated Show resolved Hide resolved
colinlyguo
colinlyguo previously approved these changes Aug 5, 2024
zimpha
zimpha previously approved these changes Aug 5, 2024
@NazariiDenha NazariiDenha dismissed stale reviews from zimpha and colinlyguo via 89bf4d9 August 14, 2024 15:29
colinlyguo
colinlyguo previously approved these changes Aug 14, 2024
@NazariiDenha NazariiDenha merged commit 27affe4 into develop Aug 18, 2024
@NazariiDenha NazariiDenha deleted the feat/not-update-fee-if-not-committing-batches branch August 18, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants