-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sender): do not bump gas price for nonce-gapped transactions #1458
Merged
0xmountaintop
merged 8 commits into
develop
from
fix-do-not-bump-gas-price-for-nonce-gapped-transactions
Aug 2, 2024
Merged
feat(sender): do not bump gas price for nonce-gapped transactions #1458
0xmountaintop
merged 8 commits into
develop
from
fix-do-not-bump-gas-price-for-nonce-gapped-transactions
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1458 +/- ##
========================================
Coverage 52.63% 52.63%
========================================
Files 156 156
Lines 12426 12435 +9
========================================
+ Hits 6540 6545 +5
- Misses 5325 5328 +3
- Partials 561 562 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zimpha
approved these changes
Aug 2, 2024
georgehao
approved these changes
Aug 2, 2024
0xmountaintop
approved these changes
Aug 2, 2024
0xmountaintop
deleted the
fix-do-not-bump-gas-price-for-nonce-gapped-transactions
branch
August 2, 2024 05:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
One of the mitigations of
commit stuck due to blob fee spike
issue:The above considerations can be done by:
tx.Nonce > confirmed nonce + 1
, then skip bumping the gas price of this transaction.basefee
andblobbasefee
with L1's at that time, leaving gas tip bumping "less aggressive" than before.Why query a full node instead of using db's confirmed status of a tx?
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?