Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coordinator): recover prover_task when the related object is verified. #1466

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

amoylan2
Copy link
Member

Purpose or design rationale of this PR

recover prover_task when the related object is verified.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@amoylan2 amoylan2 added the bump-version Bump the version tag for deployment label Jul 29, 2024
@amoylan2 amoylan2 requested a review from colinlyguo July 29, 2024 07:43
@amoylan2 amoylan2 requested a review from georgehao July 29, 2024 07:43
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.27%. Comparing base (0fd7a87) to head (590b930).

Files Patch % Lines
common/types/db.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1466      +/-   ##
===========================================
- Coverage    53.29%   53.27%   -0.02%     
===========================================
  Files          155      155              
  Lines        11770    11774       +4     
===========================================
  Hits          6273     6273              
- Misses        5002     5006       +4     
  Partials       495      495              
Flag Coverage Δ
common 49.67% <0.00%> (-0.22%) ⬇️
coordinator 19.93% <ø> (ø)
database 42.85% <ø> (ø)
rollup 56.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amoylan2 amoylan2 merged commit e22af03 into develop Jul 29, 2024
14 checks passed
@amoylan2 amoylan2 deleted the fix/recover_task_when_object_verified branch July 29, 2024 09:23
@georgehao georgehao restored the fix/recover_task_when_object_verified branch July 30, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants