Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup-relayer): move rollup logs into effective branches #1481

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Aug 14, 2024

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Aug 14, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.51%. Comparing base (160f4c4) to head (7a2c0f3).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1481      +/-   ##
===========================================
+ Coverage    52.49%   52.51%   +0.01%     
===========================================
  Files          156      156              
  Lines        12497    12502       +5     
===========================================
+ Hits          6560     6565       +5     
  Misses        5374     5374              
  Partials       563      563              
Flag Coverage Δ
rollup 57.07% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo merged commit 0313f16 into develop Aug 14, 2024
5 checks passed
@colinlyguo colinlyguo deleted the fix-move-rollup-log-to-effective-branches branch August 14, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants