Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coordinator): define new structs to map rust's config #1494

Conversation

amoylan2
Copy link
Member

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@georgehao georgehao merged commit c3a5732 into feat-coordinator-add-blob-bytes-in-batch-proving-task Aug 23, 2024
4 checks passed
@georgehao georgehao deleted the feat/utilize_libzkp_config branch August 23, 2024 03:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.90%. Comparing base (1f7bef9) to head (283a070).
Report is 1 commits behind head on feat-coordinator-add-blob-bytes-in-batch-proving-task.

Additional details and impacted files
@@                                  Coverage Diff                                   @@
##           feat-coordinator-add-blob-bytes-in-batch-proving-task    #1494   +/-   ##
======================================================================================
  Coverage                                                  51.90%   51.90%           
======================================================================================
  Files                                                        156      156           
  Lines                                                      12712    12712           
======================================================================================
  Hits                                                        6598     6598           
  Misses                                                      5548     5548           
  Partials                                                     566      566           
Flag Coverage Δ
coordinator 16.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants