-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix coordiantor assign task strategy #1495
Merged
georgehao
merged 13 commits into
feat-coordinator-add-blob-bytes-in-batch-proving-task
from
feat/fix_bug_assign_task
Aug 23, 2024
Merged
fix coordiantor assign task strategy #1495
georgehao
merged 13 commits into
feat-coordinator-add-blob-bytes-in-batch-proving-task
from
feat/fix_bug_assign_task
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-coordinator-add-blob-bytes-in-batch-proving-task #1495 +/- ##
=========================================================================================
+ Coverage 51.90% 52.01% +0.11%
=========================================================================================
Files 156 156
Lines 12712 12684 -28
=========================================================================================
Hits 6598 6598
+ Misses 5548 5520 -28
Partials 566 566
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
georgehao
requested review from
colinlyguo and
amoylan2
and removed request for
colinlyguo
August 23, 2024 08:57
…into feat/fix_bug_assign_task
colinlyguo
approved these changes
Aug 23, 2024
colinlyguo
approved these changes
Aug 23, 2024
amoylan2
approved these changes
Aug 23, 2024
georgehao
merged commit Aug 23, 2024
361d1fa
into
feat-coordinator-add-blob-bytes-in-batch-proving-task
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?