prover: upgrade to v0.13.1 / v0.12.2, share params between versions. #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto fix/coordinator-init-lifetime
lispc
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1504 +/- ##
========================================
Coverage 51.71% 51.71%
========================================
Files 156 156
Lines 12763 12763
========================================
Hits 6600 6600
Misses 5595 5595
Partials 568 568
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
georgehao
approved these changes
Aug 27, 2024
|
I think it's a little bit complicate, I'm taking a try to make it simpler based on your change |
roynalnaruto
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amoylan2 i will still fixing some remaining testing. You can first have a look to check the high level changes.
(the previous builder-of-handler-map pattern is quite complex dealing with lifetime.. since we alwasy just have 2 version, i simplify the codes. wdyt? )
btw coordinator/internal/logic/verifier/verifier_test.go is not maintained.. each time i fix that file