fix(coordinator): jwt backward compatibility #1606
Conversation
WalkthroughThis pull request makes two separate changes. The first change updates the version tag in the software by modifying the value in Changes
Sequence Diagram(s)sequenceDiagram
participant B as BaseProverTask
participant C as Context
participant D as Default Provider
B->>C: Retrieve ProverProviderType
alt ProverProviderType exists
C-->>B: Return found ProverProviderType
else ProverProviderType missing
B->>B: Set default provider to coordinatorType.ProverProviderTypeInternal
Note over B: Fallback mechanism engaged
end
Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 golangci-lint (1.62.2)level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package zstd: could not load export data: no export data for "github.com/scroll-tech/da-codec/encoding/zstd"" 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1606 +/- ##
========================================
Coverage 51.72% 51.72%
========================================
Files 157 157
Lines 12555 12555
========================================
Hits 6494 6494
Misses 5497 5497
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: yiweichi <yiweichi@users.noreply.github.com>
4 participants
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
To fix the issue when a prover holds a jwt token that dispatched by old version of coordinator, it will fail to pass the jwt token fields check, and not able to query task until jwt expires. So we should add the jwt backward compatibility here.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit