Skip to content

Fix batch header v #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

Fix batch header v #145

merged 2 commits into from
Jul 22, 2025

Conversation

@roynalnaruto
Copy link
Collaborator

The batch proving task's implementation for generating stdin for the zkvm had issues, that are being fixed here.

  1. since both BatchHeaderV8 and BatchHeaderV7 essentially refer to the same type, deserialising batch header always gave us BatchHeaderV7.
  2. the same with reference header

Upon fixing the above 2, a Feynman task can now be executed

@roynalnaruto roynalnaruto requested a review from lispc July 22, 2025 14:45
@roynalnaruto roynalnaruto requested a review from noel2004 as a code owner July 22, 2025 14:45
@github-actions github-actions bot added crate-prover Updates to the prover crate crate-integration Updates to the integration crate labels Jul 22, 2025
@lispc lispc merged commit 188e21c into feat/0.5.1 Jul 22, 2025
4 checks passed
lispc added a commit that referenced this pull request Jul 23, 2025
@lispc @roynalnaruto
0.5.2 (#144)
2fcd49f 
* 0.5.1

* add commitment

* Fix batch header v (#145)

* fix(prover): generic batch header v7/v8 the same

* fix: reference header assignment

* 0.5.2

* 0.5.2 vk json

* dump openVmVk.json in build-guest

---------

Co-authored-by: Rohit Narurkar <rohit.narurkar@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lispc lispc lispc approved these changes

@noel2004 noel2004 Awaiting requested review from noel2004 noel2004 is a code owner

Assignees

No one assigned

Labels

crate-integration Updates to the integration crate crate-prover Updates to the prover crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roynalnaruto @lispc