-
Notifications
You must be signed in to change notification settings - Fork 8
v0.6 base branch (scroll + L3) #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…over into feat/exchange-code-2
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: 1.86 | ||
| toolchain: nightly-2025-08-18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guest building needs nightly toolchain. So we also use same toolchain for host.
|
|
||
| OPENVM_RUST_TOOLCHAIN ?= nightly-2025-08-18 | ||
| export OPENVM_RUST_TOOLCHAIN | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reth needs >=1.88.
| exe: crate::commitments::chunk_exe_commit::COMMIT, | ||
| vm: crate::commitments::chunk_leaf_commit::COMMIT, | ||
| }; | ||
| let commitment = load_program_commitments("chunk")?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
support multi version guest testing better.
The goal of this PR is to "refresh" libs and clean tech debts.
Changes:
sbv_primitives::legacy_types::BlockWitnessand use reth types as much as possible as newBlockWitness. Converting functions also added. Need to be careful when integrating here.GUEST_VERSION=0.5.2 make test-e2e-bundle==================================
supress #161
make test-execute-chunkbefore(master):
after: