validium batch-bundle #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noel2004
reviewed
Aug 27, 2025
| @@ -0,0 +1,209 @@ | |||
| use alloy_primitives::{B256, keccak256}; | |||
There was a problem hiding this comment.
So we have almost identical code between validium.rs and v7.rs?
There was a problem hiding this comment.
Yes, almost identical (for now).
There are a few bound constraints in v7 that are not applicable for validium (like upper bound on number of bytes from witness). Also, future versions (v2) of validium could diverge massively, hence I have preferred creating a new module and types altogether.
github-actions
bot
added
crate-chunk-circuit
github-actions
bot
added
crate-batch-circuit
lispc
reviewed
Aug 27, 2025
| // blockhash is unused for scroll domain. | ||
| if version.domain == Domain::Scroll { | ||
| assert_eq!(self.prev_blockhash, B256::ZERO); | ||
| assert_eq!(self.post_blockhash, B256::ZERO); |
There was a problem hiding this comment.
just populate them? may be useful for future
lispc
reviewed
Aug 27, 2025
| domain: Domain::Validium, | ||
| stf_version: STFVersion::V1, | ||
| fork: ForkName::Feynman, | ||
| codec: Codec::V9, |
There was a problem hiding this comment.
so this Codec::V9 enum is something fully inner. We don't put a '0x9' byte at the beginning of DA? (instead we use 65?)
lispc
reviewed
Aug 27, 2025
| // Conditionally decode depending on the flag set in the envelope. | ||
| let payload_bytes = if envelope.is_encoded & 1 == 1 { | ||
| vm_zstd::process(&envelope.unpadded_bytes) | ||
| .expect("zstd decode should succeed") |
There was a problem hiding this comment.
haha we should rename this crate later vm_zstd::process to like rust_zstd_decompressor
|
the framework seems good. though some details i may revisit later. |
lispc
added a commit
that referenced
this pull request
Oct 29, 2025
* cargo check * fix * fix * x * exchange code * fix rebase * fmt * actually Infallible * fmt * add validium * mark todo * add test data * add test * upgrade * update openvm guest * fmt & check * update batch program * build * build * fix: remove tiny-keccak (#168) * fix merge * fix build * remove generic as no need for rkyv * fmt * make ecies openvm irrelevant * add makefile * fix download-release.sh * proving 0.5.2 * fix tx data len * feat: update sbv bincode (#169) * update ref * revert chunk_exe_commit.rs * rewrite vk in testing * sync * add script * add script * cleanup * clean much old codes * lint * clippy * update sbv * 0.6.0 * docker ignore * build * add exe_commit.rs * update * validium batch-bundle (#175) * preliminary work * chore: clippy fix * update versioned public inputs * fix: compilation for crate/integration * fix: further changes to support integration tests * fix: dir name for validium * test: with euclid-v2 for older testdata * commitment * fix: update due to upstream --------- Co-authored-by: Zhuo Zhang <mycinbrin@gmail.com> * clean * unify openvm to v1.4.0 * add old feynman witness structs * fix gpu * fix * move blob_consistency/types.rs * fix * minor improvements * clean * fmt * better logging * commits * add feature=host for types crate * fix merge * sanity check for blob * test: more data (feynman) for validium * fix: path to witnesses * feat: update public for validium * make ValidiumInputs public * chore: export version module * chore: serde for version types * chore: commitments * release: update release name to validium * fix: script syntax ? * chore: restore changes * fix building scripts * swtich back to non-force mode in gen verifier.bin * it is 1.3.. a bit tricky.. will explain later. * update guest commits * [Fix] Issues for validium mode (#194) * fix issues in e2e test with coordinator * add debug fields * update commits * Soundness issues in Validium (#196) * fix: soundness issues in validium mode * chore: rename method validium pi_hash * chore: rename another pi_hash validium * update commit --------- Co-authored-by: Zhuo Zhang <mycinbrin@gmail.com> Co-authored-by: Rohit Narurkar <rohit.narurkar@proton.me> * update sbv and reth * Merge remote-tracking branch 'origin/master' into feat/validium * release.sh be compatible with sh * resume features removed by mistake allow chunk can be built in host * fix soundness issue update commit * fix batch gen. in integration * hack some test stuff to fit the integration tests --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com> Co-authored-by: Rohit Narurkar <rohit.narurkar@proton.me> Co-authored-by: Velaciela <git.rover@outlook.com> Co-authored-by: Ho <fan@scroll.io> Co-authored-by: Ho <noelwei@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.