Galileo refactor header #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Thegaram
reviewed
Nov 18, 2025
Thegaram
left a comment
Thegaram
left a comment
There was a problem hiding this comment.
Lgtm, this makes is much clearer, thanks!
Thegaram
approved these changes
Nov 18, 2025
github-actions
bot
added
crate-chunk-circuit
Thegaram
approved these changes
Nov 18, 2025
roynalnaruto
added a commit
that referenced
this pull request
Nov 20, 2025
* chore: add galileo fork and update pi * chore: bump sbv * fix: bump sbv and fix compilation * add witness data * test: sbv update * try dbg * chore: bump sbv * fix: compilation post sbv update * test: remove witness for block xxx156 * test: update testdata * commitments * test data updated devnet3 * update test data * update first block witness (testdata galileo) * chore: bump reth + sbv * chore: commitments * chore: bump sbv+reth * commitments * chore: bump all * fix: version in blob is da-codec * fix: onchain batch header version is stf-version * fix(tests): pi-hash for e2e * tests: reduce proofgen time by changing e2e wit * commitments * chore: bump version * chore: commitments for 0.7.0-rc.1 * fix: blob's version is also stf-version * v0.7.0-rc.2 ok * chore: commitments * Galileo refactor header (#225) * refactor header to avoid duplicate variants * codec v8 no longer needed as it is identical with v7 * chore: commitments * chore: more refactoring, remove pi_hash_by_fork * chore: commitments --------- Co-authored-by: Zhuo Zhang <mycinbrin@gmail.com> * Re-introduce `ReferenceHeader::V8` for backwards compatibility with `0.5.2` (#226) * fix: re-introduce ReferenceHeader::V8 for backwards compatibility * for automatically set is_openvm_v13 flag in verifier, also recognize 0.5.6 release files * chore: fmt * chore: commitments --------- Co-authored-by: Ho <fan@scroll.io> Co-authored-by: Zhuo Zhang <mycinbrin@gmail.com> --------- Co-authored-by: Zhuo Zhang <mycinbrin@gmail.com> Co-authored-by: Ho <fan@scroll.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR refactors:
The primary purpose of doing so is to avoid any confusion from the previously added V8 (for both codec and batch header).
Since the introduction of
Version, the witness' version byte is capable of encoding both theSTFVersionas well as theCodec. Hence we no longer need additional variants of codec and batch header for v8, since the da-codec essentially remains the same.In order to provide more clarity, the PR introduces an umbrella variant
V7_V8_V9for the batch header that covers those cases.All checks related to batch header's version and blob's version byte are effectively already done using the stf-version, so we don't need any of the v8 modules. We simply re-use v7 wherever applicable.