This repository has been archived by the owner on Jun 21, 2020. It is now read-only.
Auto generate ecalls FFI rust code using bindgen in enigma-core enclave #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elichai
force-pushed
the
bindgen-core-enclave
branch
from
42e024f
to
a294978
Compare
moriaab
approved these changes
May 28, 2019
| echo $(BINDGEN_RAW_LINES) | ||
| bindgen Enclave_t.h $(BINDGEN_FLAGS) -- $(BINDGEN_CLANG_FLAGS) > $(BINDGEN_OUTPUT_FILE) | ||
| rustfmt $(BINDGEN_OUTPUT_FILE) |
There was a problem hiding this comment.
Why didn't you use rustfmt option of builder in #165?
There was a problem hiding this comment.
I'll recheck but I'm pretty sure that it doesn't run on the added raw_lines which I add them all at the same line, so rustfmt will sort them later nicely
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
build-dependenciesand regular dependencies are mixed together it's not possible to importbindgeninto the enclave'sbuild.rs(rust-lang/cargo#2589)The solution is to install the
bindgenCLI in the docker and use it manually in the Makefile.