Layout detecting, stability improvements for tile window managers and so on #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always add space between special keys (like modifiers or Esc) and alphanumerical oneletter symbols.
* KEEP_POS is not by default, means user can drag window wherever one wants; * background and foreground colors can be changed via command line flags; * process will be terminated no matter how it's closed (bug in Xlib impl);
This proposed character is Unicode 'ERASE TO THE LEFT' (U+232B)
First error happens upon launch. `unichr()` can't accept values for multimedia keys, as they are outside the Unicode range. Second error happens when trying to set a label to a string containing null characters.
Mostly whitespace. Also moved GTK/GDK threading initialization to inside main().
Fixing Unicode error and other stuff
I accidentally switched the default in the previous commit(s). I'm reverting it. However, I'm somewhat inclined to remove this option… But not now.
|
@scs3jb: hey, how are you?
|
|
Hi, will take a look! This was also a quick and nasty for a web capture I needed to do, you've put a lot of work into cleaning this up. |
|
I was just looking at merging this since its a long time since I used this, and updating some dependencies when I saw a version that's more modern: https://gitlab.com/screenkey/screenkey , might be worthwhile using that as a future base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'l be huge.
Overview of features introduced by this PR available here: https://github.com/seletskiy/screenkey#whats-up
I rewrote several blocks of code so I'm not 100% sure it will work on every configuration.
Please let me know what do you think.