Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overseer with lidarr support #3800

Closed
wants to merge 31 commits into from

Conversation

ano0002
Copy link

@ano0002 ano0002 commented Mar 3, 2024

Description

Implemented Lidarr Support into overseerr

Here is a sample docker-compose.yml for it :

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 5055:5055
    volumes:
      - .:/app:rw,cached
      - /app/node_modules
      - /app/.next

.gitignore Outdated Show resolved Hide resolved
@ano0002 ano0002 force-pushed the overseer-with-lidarr-support branch from 2e7f050 to 078c8b0 Compare April 6, 2024 14:36
@ano0002 ano0002 requested a review from samwiseg0 as a code owner April 6, 2024 14:36
@ano0002
Copy link
Author

ano0002 commented Apr 6, 2024

I just rebased all the commits, it's all in your hands now !

ano0002 added 5 commits April 28, 2024 15:54
Added some fields I missed in the migration file and fixed some image
display issue
…nly a <Link>

Ported Links to work for the new React version installed
…maps to await them

I changed mapMovieResult and other equivalents to return Promises and forgot to fix some API
endpoints. So that's fixed now.
@githubaccount3322
Copy link

brilliant, hope this gets approved

@ano0002
Copy link
Author

ano0002 commented Jun 4, 2024

I'll repost here what I said on discord:

I temporarly pushed it to docker hub for anyone wanting to try it out but who don't want to build it: https://hub.docker.com/r/ano002/overseerr-lidarr
I'll delete it as soon as it gets merged.

And also:

Now that I'm using only the lidarr overseerr I found some bugs:

  • the Jobs & Cache page crashes in settings
  • even though they are in the backend I forgot to add the possibility change music quotas etc for users in the frontend

If you have found any other issues please report them to me

@ano0002
Copy link
Author

ano0002 commented Jun 18, 2024

the Jobs & Cache page crashes in settings

Just fixed this

@ano0002
Copy link
Author

ano0002 commented Jun 18, 2024

Even though they are in the backend I forgot to add the possibility change music quotas etc for users in the frontend

Fixed this too

@ano0002
Copy link
Author

ano0002 commented Sep 17, 2024

Good afternoon. I want to see how the integration with ldap works, I'm trying to run docker. It gives an error when starting. What should I do to launch the docker container?

yarn run v1.22.19
error Couldn't find a package.json file in "/app"
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

What does your docker compose look like ?

@Druidblack
Copy link

Druidblack commented Sep 17, 2024

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 6165:5055
    volumes:
      - /srv/config/overseerrlidarr:/app:rw,cached
      - /app/node_modules
      - /app/.next

@ano0002
Copy link
Author

ano0002 commented Sep 17, 2024

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 6165:5055
    volumes:
      - /srv/config/overseerrlidarr:/app:rw,cached
      - /app/node_modules
      - /app/.next

You haven't mapped anything to /app

@Druidblack
Copy link

Druidblack commented Sep 17, 2024

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 6165:5055
    volumes:
      - /srv/config/overseerrlidarr:/app:rw,cached
      - /srv/config/overseerrlidarr:/app/node_modules
      - /srv/config/overseerrlidarr:/app/.next

yarn run v1.22.19
error Couldn't find a package.json file in "/app"
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I've mapped all the folders. The error about missing files is still preserved.

@zolakk
Copy link

zolakk commented Sep 27, 2024

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 6165:5055
    volumes:
      - /srv/config/overseerrlidarr:/app:rw,cached
      - /srv/config/overseerrlidarr:/app/node_modules
      - /srv/config/overseerrlidarr:/app/.next

yarn run v1.22.19 error Couldn't find a package.json file in "/app" info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I've mapped all the folders. The error about missing files is still preserved.

I had the same problem and switching from bind mount to docker volumes fixed it. It appears that for whatever reason (permissions?) this is one that just won't work correctly with bind mounts unless you want to pre-download everything into your mount folder first. I had the same issue with the emqx docker too and just gave up on fighting that one after many days of fighting it.

@ano0002
Copy link
Author

ano0002 commented Sep 30, 2024

Pushed a new build to docker with some fixes

@Gauvino
Copy link
Contributor

Gauvino commented Sep 30, 2024

First of all thanks for all the job you done @ano0002.
I have some question please:

  1. Why still having the PR in draft since it's ready to deploy now no other work needs to be done to it other than bug fix.
  2. Are you planning to add this change on jellyseerr?

@ano0002
Copy link
Author

ano0002 commented Sep 30, 2024

First of all thanks for all the job you done @ano0002.
I have some question please:

  1. Why still having the PR in draft since it's ready to deploy now no other work needs to be done to it other than bug fix.
  2. Are you planning to add this change on jellyseerr?
  1. I expect to have a fork with fewer bugs to deploy and merge it. However you can use the docker image I host if you can't wait and/or want to help me track bugs.

  2. No, I'm not using it and adding it to Overseerr already took a long time so no

@jbishop123
Copy link

I am new to the whole docker ecosystem. Currently using Unraid. I did the docker pull and then docker run. How do I get the apps linked so music shows up in Overseerr? Any help would be greatly appreciated!

@nhatlinh1982
Copy link

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 6165:5055
    volumes:
      - /srv/config/overseerrlidarr:/app:rw,cached
      - /srv/config/overseerrlidarr:/app/node_modules
      - /srv/config/overseerrlidarr:/app/.next

yarn run v1.22.19 error Couldn't find a package.json file in "/app" info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
I've mapped all the folders. The error about missing files is still preserved.

I had the same problem and switching from bind mount to docker volumes fixed it. It appears that for whatever reason (permissions?) this is one that just won't work correctly with bind mounts unless you want to pre-download everything into your mount folder first. I had the same issue with the emqx docker too and just gave up on fighting that one after many days of fighting it.

While I appreciate you pointed to the solution, alot of us here are clueless to how to mount to docker volumes. I ask chatGPT for help and this solved the issue:

version: '3'
services:
overseerr:
build:
context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
args:
COMMIT_TAG: c105f10
dockerfile: Dockerfile.local
ports:
- 6165:5055
volumes:
- overseerr_config:/app
- overseerr_node_modules:/app/node_modules
- overseerr_next:/app/.next

volumes:
overseerr_config:
overseerr_node_modules:
overseerr_next:

@d4nm0
Copy link

d4nm0 commented Nov 4, 2024

Hello, where are we with the final integration to overseer? @sct

@RecoX
Copy link

RecoX commented Nov 12, 2024

Merge this already!!!!

@eco9898
Copy link

eco9898 commented Dec 27, 2024

Merge this already!!!!

The request will not be merged while the creator has marked it as a draft. Until @ano0002 is happy with the feature it will remain in development and not be reviewed for release.

@xHyperElectric
Copy link

@ano0002 make this no longer a draft so this can be merged please

@ano0002
Copy link
Author

ano0002 commented Jan 12, 2025

Hey everyone, I've finally got some time to work on this again. Thanks for waiting!
I've been looking at what people around have been doing and 0-Pierre (who has been working on adding music to jellyseer based on what I did but with lots of improvements) just posted a pull request to jellyseer.
I will try to use his work and retrofit it to overseerr hoping to finally have a version I can be satisfied with !

@andrewlasuen
Copy link

Wanted to say thanks for your work on this @ano0002.

Hey everyone, I've finally got some time to work on this again. Thanks for waiting! I've been looking at what people around have been doing and 0-Pierre (who has been working on adding music to jellyseer based on what I did but with lots of improvements) just posted a pull request to jellyseer. I will try to use his work and retrofit it to overseerr hoping to finally have a version I can be satisfied with !

Glad you have time! Can't say how excited I am for this feature!

@ano0002
Copy link
Author

ano0002 commented Jan 18, 2025

Hey everyone, I've finally got some time to work on this again. Thanks for waiting! I've been looking at what people around have been doing and 0-Pierre (who has been working on adding music to jellyseerr based on what I did but with lots of improvements) just posted a pull request to jellyseerr. I will try to use his work and retrofit it to overseerr hoping to finally have a version I can be satisfied with !

To include what 0-Pierre did, I'm rewriting most of what I already did but it should allow for:

  • an overview section which pulls data from Wikipedia
  • faster search using Lidarr instead of MusicBrainz
  • better API structure

(This was all done by him and I'm just porting from jellyseerr to overseerr for now)

@ano0002
Copy link
Author

ano0002 commented Feb 1, 2025

Hard drive failure, Project is aborted

I have been trying to recover the past three weeks progress for abt 8hrs straight and haven't been able to. The overseerr with lidarr project is aborted (or at least on long hold). I just lost abt 3hrs of work for abt 21 days so a bit above 60hrs of work on Overseerr down the drain. Sorry to those who expected a stable release but I can't continue on at least now.
I am drained and lost more than just my Overseerr lidarr progress.
The project however is open-source so feel free to fork it or do pull request if you want, I would even be glad to answer questions about the current implementation if needed.
Also, there is still a working (mostly) release published on docker-hub (here).
And I would also suggest taking a look at the Jellyseerr implementation of it which is more polished while still in development (here).

(PS: For those wondering I didn't push it on github as I didn't want people to start messaging me again, I know most people have common sense but sadly not everyone)

@ano0002 ano0002 closed this Feb 1, 2025
@RecoX
Copy link

RecoX commented Feb 1, 2025

Hard drive failure, Project is aborted

I have been trying to recover the past three weeks progress for abt 8hrs straight and haven't been able to. The overseerr with lidarr project is aborted (or at least on long hold). I just lost abt 3hrs of work for abt 21 days so a bit above 60hrs of work on Overseerr down the drain. Sorry to those who expected a stable release but I can't continue on at least now. I am drained and lost more than just my Overseerr lidarr progress. The project however is open-source so feel free to fork it or do pull request if you want, I would even be glad to answer questions about the current implementation if needed. Also, there is still a working (mostly) release published on docker-hub (here). And I would also suggest taking a look at the Jellyseerr implementation of it which is more polished while still in development (here).

(PS: For those wondering I didn't push it on github as I didn't want people to start messaging me again, I know most people have common sense but sadly not everyone)

So are you going to try again tomorrow ?

@cohenchris
Copy link

@RecoX

I know most people have common sense but sadly not everyone

@n00b001
Copy link

n00b001 commented Feb 1, 2025

@ano0002 take care of yourself and come back when you're ready

It is such a heartbreak when permanent data loss occurs

Maybe someone else will pick up the flame in your absence

I look forward to your PR @RecoX

@ThisIsTheOnlyUsernameAvailable

Hard drive failure, Project is aborted

Sorry for your loss. We've all had at least one major data loss and it profoundly sucks.

Good luck on the recovery process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.