Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide trailer in a fallback language when the original TMDB request doesn't provide one in the chosen localization #4009

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

StancuFlorin
Copy link

@StancuFlorin StancuFlorin commented Jan 2, 2025

Description

When localizing to a language other than English, the data retrieved from TMDb is also localized to that language. As a result, the relatedVideos data attached to a movie in Overseerr may lack the necessary information to display the "view trailer" button on the movie/TV show details page.

Fortunately, the TMDb API supports multi-language requests, allowing you to fetch video data in multiple languages.
https://www.themoviedb.org/talk/6712613425c70b8b1d67ba57?page=1

I know that the request to TMDb includes include_video_language=en, en when using English. However, I think that this is a small trade-off compared to adding an additional conditional check in the code.

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

…, for related videos of a movie or TV show
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant