Backport event loop support from usrsctp-neat

[lgrahl]

Would be the only thing left I need to be able to use the upstream usrsctp in RAWRTC. 🙂

[weinrank]

PRs welcome! :)

[ibc]

PRs welcome! :)

PR does exist: #38. It was just discarded because "Support for external event loop is being worked on in the NEAT fork or usrsctp to get some experience. This will be merged eventually." However usrsctp-neat is not active at all.

[lgrahl]

AFAIK they are not entirely identical approaches but I don't actually care about which is being merged... obviously, it should be the better one. Speaking for myself, I guess one of the reasons why it takes so long is that #38 is huge and should be split up into small, digestible PRs.

[lgrahl]

Maybe you should talk to @tuexen and @weinrank on how to approach the issue of backlogged PRs. Luckily, #300 is not a pressing issue for me... at least before this issue has been resolved.

[ibc]

We'll do separate and specific PRs for both single-thread and GYP support. We'll fight them once done :)

[dreibh]

Is there any update on merging the changes of usrsctp-neat, or making libneat work with the upstream version of usrsctp?

[tuexen]

I'm not sure if anyone is working on neat right now...

[ibc]

Hi, we forked usrsctp and added "single-thread" support. It's identical to PR #38 but does not include changes other than those to allow single thread operation:

master...versatica:single-thread

We are using it and works fine. Would you accept a PR?

[tuexen]

If it is a PR adding only that feature and not breaking backwards compatibility, I would love to integrate it.

[ibc]

Great, will do it soon. El mar., 6 ago. 2019 13:29, Michael Tüxen <notifications@github.com> escribió:

…

If it is a PR adding only that feature and not breaking backwards compatibility, I would love to integrate it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#292?email_source=notifications&email_token=AAAD6P57VL4PPQE4QMHSDXDQDFOA5A5CNFSM4GPEDWR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3U2S5I#issuecomment-518629749>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAD6PZ3GDVH3JMBW6GCENDQDFOA5ANCNFSM4GPEDWRQ> .

[jmillan]

@tuexen,

Please find the PR #339 synchronised with master branch. It's essentially a cleanup of #38 with everything filtered but the the single thread implementation.

I can squash the commits into a single one if you like.

[tuexen]

@lgrahl Can this be closed since we have f6aa4b0 in the master tree now?

[lgrahl]

Yup. If there's anything missing, I'll reopen.

[lgrahl]

Works well - thanks a lot!