Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes buffer size can be setting up from properties #192

Merged
merged 1 commit into from
May 13, 2018

Conversation

Fabszn
Copy link
Contributor

@Fabszn Fabszn commented May 11, 2018

This PR aims to propose a way to setting up the buffer size of stream.

Currently i am faced with an issue, because I loose some messages (by droptail) in pre-production

Copy link
Owner

@scullxbones scullxbones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this works for me. Thanks for the contribution including the docs!

@scullxbones scullxbones merged commit 1add327 into scullxbones:master May 13, 2018
@Fabszn
Copy link
Contributor Author

Fabszn commented May 13, 2018

Many thanks for your merged.
Do you know when a new release could be done ?

@scullxbones
Copy link
Owner

I was thinking of putting it together with #190, but that one is a bit stalled out now. Will give it another day and if it doesn't get moving, will get this one released by itself.

@Fabszn
Copy link
Contributor Author

Fabszn commented May 13, 2018

Thanks for your answer. It is perfect! Many thanks

@scullxbones
Copy link
Owner

Released with v2.0.10 - thanks for the contribution!

@Fabszn
Copy link
Contributor Author

Fabszn commented May 16, 2018

Many many thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants