Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TransferStateService undependable off idleService #239

Closed
SanderElias opened this issue Jan 26, 2020 · 0 comments · Fixed by #246
Closed

Make TransferStateService undependable off idleService #239

SanderElias opened this issue Jan 26, 2020 · 0 comments · Fixed by #246
Assignees
@SanderElias
Labels
bug Something isn't working

Comments

@SanderElias
Copy link
Contributor

The transferState doesn't work after a timeout, only when the idleservice is used.
The code that injects the needed globals is triggered only on idleService and not on timeout
@SanderElias SanderElias added the bug Something isn't working label Jan 26, 2020
@SanderElias SanderElias self-assigned this Jan 26, 2020
@stewones stewones mentioned this issue Jan 26, 2020
Closed
10 tasks
SanderElias added a commit that referenced this issue Jan 28, 2020
@SanderElias
fix(pupperteerrenderplugn.ts): inject scully content on both timeout …
44e3957 
…and scully-ready event

closes #239
@SanderElias SanderElias mentioned this issue Jan 28, 2020
Merged
10 tasks
SanderElias added a commit that referenced this issue Jan 28, 2020
@SanderElias
fix(pupperteerrenderplugn.ts): inject scully content on both timeout …
81ad5e9 
…and scully-ready event (#246)

closes #239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SanderElias SanderElias

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pupperteerrenderplugn.ts): inject scully content on timeout scullyio/scully
1 participant
@SanderElias