Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use defined project prefix if set #27

Closed
d-koppenhagen opened this issue Dec 16, 2019 · 2 comments
Closed

use defined project prefix if set #27

d-koppenhagen opened this issue Dec 16, 2019 · 2 comments
Assignees
Labels
bug Something isn't working schematics

Comments

@d-koppenhagen
Copy link
Contributor

generating a blog using scully should use the defined app prefix from angular.json file instead of always app.

Running this:

ng g @scullyio/init:blog

... will currently always lead to this blog.component.ts file content:

...
@Component({
  selector: 'app-blog',
  ...
})
...

If a prefix is set in angular.json (path: projects => <project name> => prefix) it should be used by scully for setting it:

{
  "$schema": "./node_modules/@angular/cli/lib/config/schema.json",
  ...
  "projects": {
    "my-project": {
      ...
      "prefix": "foo",
    }
  }
}  
...
@Component({
  selector: 'app-blog',
  ...
})
...
@jorgeucano jorgeucano self-assigned this Dec 17, 2019
@jorgeucano jorgeucano added bug Something isn't working schematics labels Dec 17, 2019
@jorgeucano
Copy link
Contributor

thanks for the issue!
WIP in schematics/project-prefix

jorgeucano added a commit that referenced this issue Dec 17, 2019
Support project prefix (issue #27 )
Support for differents routes files (app-routing // app.module)
remove blog schematics functions, and just call markdown schematics with options
Remove cli module create, and use schematics for inject the lazy route
add support for multiples project prefix
@jorgeucano
Copy link
Contributor

fixed and merged :) thanks for report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working schematics
Projects
None yet
Development

No branches or pull requests

2 participants