Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't install when angular.json contains comments. #480

Closed
hannson opened this issue Apr 20, 2020 · 1 comment
Closed

Doesn't install when angular.json contains comments. #480

hannson opened this issue Apr 20, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@hannson
Copy link

hannson commented Apr 20, 2020

🐞 Bug report

Description

If angular.json contains a comment then ng add @scullyio/init fails with an error.

Strictly speaking JSON should not contain comments but it is supported in Angular configuration and is added in some schemas.

Workaround

Remove any comment from angular.json (and/or possibly other json files parsed by @scully/init.

🔬 Minimal Reproduction

Add a comment to angular.json and try to install scully.

💻Your Environment

Angular Version:




Angular CLI: 9.1.0
Node: 13.13.0
OS: linux x64

Angular: 9.1.0
... animations, bazel, cli, common, compiler, compiler-cli, core
... forms, language-service, localize, platform-browser
... platform-browser-dynamic, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.901.0
@angular-devkit/build-angular     0.901.0
@angular-devkit/build-optimizer   0.901.0
@angular-devkit/build-webpack     0.901.0
@angular-devkit/core              9.1.0
@angular-devkit/schematics        9.1.0
@bazel/bazel                      2.1.0
@bazel/hide-bazel-files           1.5.0
@bazel/ibazel                     0.12.3
@bazel/karma                      1.5.0
@bazel/protractor                 1.5.0
@bazel/typescript                 1.5.0
@ngtools/webpack                  9.1.0
@schematics/angular               9.1.0
@schematics/update                0.901.0
rxjs                              6.5.4
typescript                        3.8.3
webpack                           4.42.0

Scully Version:
latest




"@scullyio/init": "0.0.25",
"@scullyio/ng-lib": "latest",
"@scullyio/scully": "latest",

🔥 Exception or Error




        error into import SculyLib
    Unexpected token / in JSON at position 0
@hannson hannson added the bug Something isn't working label Apr 20, 2020
@SanderElias SanderElias added enhancement New feature or request and removed bug Something isn't working labels Apr 20, 2020
atao60 added a commit to atao60/scully that referenced this issue May 6, 2020
atao60 added a commit to atao60/scully that referenced this issue May 14, 2020
@jorgeucano
Copy link
Contributor

Hey i will check your PR this weekend! thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants