Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Schematics] remove unnecessary boilerplate #746

Closed
geromegrignon opened this issue Jul 15, 2020 · 1 comment
Closed

[Schematics] remove unnecessary boilerplate #746

geromegrignon opened this issue Jul 15, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@geromegrignon
Copy link
Contributor

geromegrignon commented Jul 15, 2020 •
edited
Loading

🧩 Feature request

Description

A clear and concise description of the problem or missing capability...

When using the blog support with ng generate @scullyio/init:blog there is unnecessary boilerplate inside the BlogComponent :

  • a var ng
  • the route and the router are injected but aren't used (and aren't required later on as a standard)
  • preserveWhitespaces setted as true is redondant with default behaviour
  • ViewEncapsulation setted as Emulated is redondant with default behaviour

Describe the solution you'd like

If you have a solution in mind, please describe it.

Remove this boilerplate

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?
@geromegrignon geromegrignon added the enhancement New feature or request label Jul 15, 2020
@geromegrignon geromegrignon mentioned this issue Jul 15, 2020
Merged
10 tasks
@SanderElias
Copy link
Contributor

Thanks @geromegrignon! closed with the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SanderElias @geromegrignon