Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(schematics): remove boilerplate #747

Merged
merged 1 commit into from
Jul 16, 2020
Merged

refactor(schematics): remove boilerplate #747

merged 1 commit into from
Jul 16, 2020

Conversation

geromegrignon
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

There is unnecessary code inside the BlogComponent file generated with the blog support.

Issue Number: #746

What is the new behavior?

The boilerplate code is removed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

remove boilerplate on blog support
Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you,
We discussed & forgot this a couple of times!

@SanderElias SanderElias merged commit a993903 into scullyio:main Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants