Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide --host flag for alternative hosts (otherwise scully not works) #87

Closed
willi84 opened this issue Dec 24, 2019 · 2 comments · Fixed by #187
Closed

provide --host flag for alternative hosts (otherwise scully not works) #87

willi84 opened this issue Dec 24, 2019 · 2 comments · Fixed by #187
Assignees
@SanderElias
Labels
enhancement New feature or request

Comments

@willi84
Copy link
Contributor

willi84 commented Dec 24, 2019

🧩 Feature request

Description

For some working environments, where localhost is by default not available to use (e.g. strict company VMs).
When I start npm run scully the mechanism tries to connecto to http://localhost:1864/_pong. But this is not possible in my enviroment, because it redirects to http://myhost:1864/_pong

Describe the solution you'd like

Angular provides for ng serve a --host flag, this could be also a solution for you.
The first line it crashed for me was here:

scully/scully/utils/waitForServerToBeAvailable.ts

Line 13 in 8ce6c13

httpGetJson('http://localhost:1864/_pong', {suppressErrors: true})

But there are maybe also other points.

Describe alternatives you've considered

I tried to edit it directly in the source code. It worked until the next issue (no chromium available for my OS)
@willi84 willi84 added the enhancement New feature or request label Dec 24, 2019
@willi84 willi84 mentioned this issue Dec 24, 2019
Closed
@SanderElias SanderElias self-assigned this Dec 31, 2019
@aaronfrost
Copy link
Contributor

@jorgeucano is this replaced with the feature you are adding around hostUrl?

@jorgeucano
Copy link
Contributor

@aaronfrost Yes, WIP

SanderElias added a commit that referenced this issue Jan 16, 2020
@SanderElias
feat(hostname): puts in a hostname option
e2a5488 
on some computers, localhost isn't avaialble. This pr takes care of that by making the name to be
used an setting

closes #87
@SanderElias SanderElias mentioned this issue Jan 16, 2020
Merged
10 tasks
jorgeucano pushed a commit that referenced this issue Jan 16, 2020
@SanderElias @jorgeucano
feat(hostname): puts in a hostname option (#187)
958d581 
* feat(hostname): puts in a hostname option

on some computers, localhost isn't avaialble. This pr takes care of that by making the name to be
used an setting

closes #87

* docs(scully-configuration docs): update the docs to reflect new settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SanderElias SanderElias

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(hostname): puts in a hostname option scullyio/scully
4 participants
@aaronfrost @SanderElias @jorgeucano @willi84