Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(scully): add husky and pretty-quick #147

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Conversation

Villanuevand
Copy link
Contributor

#143

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: #143

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there more configuration needed for the prettier to run?
Aside from that, LGTM

@Villanuevand
Copy link
Contributor Author

@SanderElias

yeap! The magic behind is made by precise-commits....

But, Im going to change by pretty-quick

Why

Pretty documentation says:

precise-commits

Use Case: Great for when you want partial file formatting on your changed/staged files.

pretty-quick

Use Case: Great for when you want an entire file formatting on your changed/staged files.

@Villanuevand Villanuevand changed the title refactor(scully): add husky and precise-commits refactor(scully): add husky and pretty-quick Jan 6, 2020
@aaronfrost aaronfrost merged commit 68658ec into master Jan 7, 2020
@aaronfrost aaronfrost deleted the pre-commit-prettier branch January 7, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants