Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(scully): additional query parameter info #1583

Merged
merged 1 commit into from
Apr 28, 2022
Merged

docs(scully): additional query parameter info #1583

merged 1 commit into from
Apr 28, 2022

Conversation

TheCodingWaffle
Copy link
Contributor

Clarification on query strings and parameterized routes

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Missing information on query strings / parameters and dynamic routes.

Issue Number: N/A

What is the new behavior?

Adding additional information on the subject of query strings / parameters and Angular parameterized routes to the Q & A section to assist others. Updated Angular routes title to include Parameterized to hopefully directly route future searchers to the appropriate information.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Clarification on query strings and parameterized routes
@CLAassistant
Copy link

CLAassistant commented Apr 27, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheCodingWaffle Thanks for putting your hard-learned lessons in a FAQ!

@SanderElias SanderElias merged commit bcad592 into scullyio:main Apr 28, 2022
@TheCodingWaffle TheCodingWaffle deleted the docs-unhandled-routes branch April 28, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants