Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add polyfill.md #179

Merged
merged 1 commit into from
Jan 13, 2020
Merged

docs: add polyfill.md #179

merged 1 commit into from
Jan 13, 2020

Conversation

evolkmann
Copy link
Contributor

@evolkmann evolkmann commented Jan 11, 2020

The Event() constuctor is used in the project. To make this work in Internet Explorer, a polyfill is required.

The new document describes the polyfilling process.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Docs

What is the current behavior?

Issue Number: N/A

Scully is currently not working in Internet Explorer.

What is the new behavior?

The new doc describes the necessary polyfilling process.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reference to usage of new Event():

private initApp = new Event('AngularInitialized', {bubbles: true, cancelable: false});
private appReady = new Event('AngularReady', {bubbles: true, cancelable: false});
private appTimeout = new Event('AngularTimeout', {bubbles: true, cancelable: false});

The `Event()` constuctor is used in the browser. To make this work in Internet Explorer, a polyfill is required.

The new document describes the polyfilling process.
@SanderElias
Copy link
Contributor

@evolkmann You are aware that those events are only used inside our puppeteer rendering process, and that that is inheritly not Ie?

@evolkmann
Copy link
Contributor Author

Hi @SanderElias, I was not aware of that, but still it caused our app to crash. With the polyfill enabled, the error did not occur again. Here is a screenshot of the error report:
Bildschirmfoto 2020-01-11 um 14 09 43

@SanderElias
Copy link
Contributor

SanderElias commented Jan 11, 2020 via email

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanderElias SanderElias merged commit 7392081 into scullyio:master Jan 13, 2020
@evolkmann
Copy link
Contributor Author

Hi @SanderElias, thanks for merging. Just curious, is it planned to remove the firing of those events in the browser at some point? Or is it indeed right that this code is executed in the browser?

@evolkmann evolkmann deleted the docs/polyfills branch January 13, 2020 12:19
@SanderElias
Copy link
Contributor

Yes, I made a note to take care of this, but it can take a while before I get around to that. That's why I merged your docs PR, so anyone running into this can fund out the cause in the docs.

@evolkmann
Copy link
Contributor Author

Alright, thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants