Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): exported scullyConfig #222

Merged
merged 1 commit into from
Jan 23, 2020
Merged

chore(config): exported scullyConfig #222

merged 1 commit into from
Jan 23, 2020

Conversation

samvloeberghs
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Currently the scullyConfig needs to be imported from@scullyio/scully/utils/config.

Issue Number: N/A

What is the new behavior?

With the change we can import the scullyConfig from @scullyio/scully

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanderElias SanderElias merged commit 6ee2b01 into scullyio:master Jan 23, 2020
@samvloeberghs samvloeberghs deleted the patch-2 branch January 23, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants