Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lib): fix a test #347

Merged
merged 1 commit into from
Mar 3, 2020
Merged

test(lib): fix a test #347

merged 1 commit into from
Mar 3, 2020

Conversation

aaronfrost
Copy link
Contributor

Test was testing the same thing twice. Updated to test the mock.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Test was testing the same thing twice. Updated to test the mock.
Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeucano jorgeucano self-requested a review March 3, 2020 13:31
@SanderElias SanderElias merged commit de98601 into master Mar 3, 2020
@SanderElias SanderElias deleted the frost/fix-test branch March 3, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants