Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scully): handle # and ? in urls properly #516

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

SanderElias
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

When there is a search param ? or a hash # in the URL, Scully rendered pages might fail

Issue Number: N/A

What is the new behavior?

Scully generated pages now ignore those parts fo the URL, as there is no way those can be stored n a file system

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@SanderElias SanderElias merged commit c9d2853 into master Apr 28, 2020
@SanderElias SanderElias deleted the sander/hashAndQueries branch April 28, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants