Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): broken link #661

Merged
merged 2 commits into from
Jul 1, 2020
Merged

fix(docs): broken link #661

merged 2 commits into from
Jul 1, 2020

Conversation

geromegrignon
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

On the doc app, there is no corresponding route for the DOCS link in the footer

What is the new behavior?

The route matchs the Introduction route.

Does this PR introduce a breaking change?

  • Yes
  • No

change the routerLink url to an existing route
@geromegrignon geromegrignon changed the title fix docs link fix(docs): broken link Jun 29, 2020
@SanderElias SanderElias merged commit 36e6c37 into scullyio:main Jul 1, 2020
@geromegrignon
Copy link
Contributor Author

@SanderElias for further contributions on the doc, do you want me to push the updated jest snapshot or you prefer to keep control on it?

@SanderElias
Copy link
Contributor

@geromegrignon Feel free to push the updated snapshots. as long as its just docks snapshot that are changing.
We added this to the test suite because we now do an automated deploy, and we want to be sure the docs build.
Also, the docs use a different render path as our sample-blog and this makes sure both paths are working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants