Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ng-lib): correct httpclient import #69

Merged
merged 1 commit into from
Dec 20, 2019
Merged

fix(ng-lib): correct httpclient import #69

merged 1 commit into from
Dec 20, 2019

Conversation

SanderElias
Copy link
Contributor

Instead of loading in the module in ng-lib get the httpclient dep

closes #52

@SanderElias
fix(ng-lib): correct httpclient import
6b956fc 
Instead of loading in the module in ng-lib get the httpclient dep

closes #52
@SanderElias SanderElias merged commit f355610 into master Dec 20, 2019
@SanderElias SanderElias deleted the sander/fi-httpclientmodule-dep branch December 20, 2019 11:57
@LayZeeDK LayZeeDK mentioned this pull request Dec 20, 2019
Merged
@LayZeeDK LayZeeDK mentioned this pull request Jan 5, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeucano jorgeucano jorgeucano approved these changes

@aaronfrost aaronfrost Awaiting requested review from aaronfrost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The ComponentsModule is importing HttpClientModule
2 participants
@SanderElias @jorgeucano