Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scully): provide full HandledRoute for preRender #690

Merged
merged 2 commits into from
Jul 3, 2020
Merged

feat(scully): provide full HandledRoute for preRender #690

merged 2 commits into from
Jul 3, 2020

Conversation

stevermeister
Copy link
Contributor

@stevermeister stevermeister commented Jul 3, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

preRender(route.route, route.config)

What is the new behavior?

preRender(route: HandledRoute)

Does this PR introduce a breaking change?

  • Yes
  • No

for all adopters who already used preRender, they need to make a small tweak with parameters

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanderElias SanderElias merged commit 4e7263e into scullyio:main Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants