-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): clarify public backed sparse docstring/api #1608
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
==========================================
- Coverage 86.83% 84.30% -2.54%
==========================================
Files 37 37
Lines 6016 6000 -16
==========================================
- Hits 5224 5058 -166
- Misses 792 942 +150
|
So you want us to commit to the whole API? If not necessarily: There are ways to make users see only part of it, I can help with that. |
Sorry went to lunch before getting to that. I made private what I thought should be, and left what I thought should be public as such. Feel free to comment otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I don’t think we want people to manually initialize it, but I think not much harm is done if they try do do that.
For #1598 (review)
Perhaps should go in separately to
main
as it is a cleaner git blame IMO